Improve IR compilation performance #18282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I guessed, this was expensive. using a vector and reserve isn't very. It's nice to keep this before logBlocks_ is > 0, in case it's set mid block.
This improves compilation performance, because all those lookups were adding up.
|
Well aliasing fields is done with anonymous (or not anonymous, depending on preference) unions, which is what you're doing - I don't know in what other ways they could be aliased? |
|
Maybe should add a comment that the struct you union IRInst with needs to be kept in sync with the original IRInst, although can do in a later commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves compilation speed (as seen using freeze frame.) A lot of time was spent in the GetIRMeta() lookup, and caching it ends up being worthwhile in the cases where it's called a lot.
A surprising amount of time is spent in
FindBestToSpill()still, it might make sense to cache some spill information at block start instead.The IRInst struct duplication is a bit non-ideal, but I didn't want to make everything
inst.i.src1and etc. I added a static assert, at least, to hopefully catch if one is updated without the other. I wish C++ had some way to alias fields easily (or maybe it does and I just don't know of it...)-[Unknown]