Add SSE2 version of vfpu_dot #18289
Merged
Add SSE2 version of vfpu_dot #18289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See hrydgard#18249. Speedup for this function ranges 10%..100%, depending on system. Updated verification and speed measurements: https://godbolt.org/z/W1z3sj6hz
hrydgard
reviewed
Oct 2, 2023
Core/MIPS/MIPSVFPUUtils.cpp
Outdated
Comment on lines
882
to
884
| #endif | ||
| return vfpu_dot_cpp(a, b); | ||
| } |
There was a problem hiding this comment.
please do an #else, if nothing else for clarity.
|
On a completely unrelated note, "JIT from IR" currently crashes in both local build and win32 build from buildbot ( |
|
And in another unrelated note, Jit using IR is no longer crashing on Mac M1, for whatever reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #18249. Speedup for this function ranges 10%..100%, depending on system. Updated verification and speed measurements: https://godbolt.org/z/W1z3sj6hz
Please feel free to double-check that it matches the current version (previous code - and verification - were wrong around NaNs, this is hopefully correct).