Fix atrac sound loop problem #18414
Fix atrac sound loop problem #18414
Conversation
|
Nice one, this looks really promising - I haven't checked all the logic yet, but it really does look like we were missing that extra offset there. Will look a little bit closer and then likely merge so this can get wider testing. |
| if (atrac->bufferState_ == ATRAC_STATUS_STREAMED_LOOP_FROM_END && numSamples + atrac->currentSample_ > atrac->endSample_) { | ||
| atrac->bufferState_ = ATRAC_STATUS_ALL_DATA_LOADED; |
There was a problem hiding this comment.
This doesn't really make sense.
The "loop from end" state basically means that you have a 200 KB music file but have a buffer that is 100 KB. So it can obviously never fully fit inside that buffer. ATRAC_STATUS_ALL_DATA_LOADED means the entire music file has been fit inside the provided buffer.
What led you to believe it should transition the state here?
-[Unknown]
There was a problem hiding this comment.
It just repeat that play the buffer.it would call sceAtracReleaseAtracID when play another Atrac
Fix #14058 fix #14352
Fix all games loop which use sceAtracGetNextSample
Full of buffer so that no need more atrac data
Modify log:
https://gist.github.com/sum2012/280ebd259a338cbcccbd980caf8bbac0