CwCheatScreen::LoadCheatInfo wait for GameInfo to be ready #18733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kethen
force-pushed
the
cwcheat_android_fix
branch
from
703baec
to
6df9ea3
Compare
|
Thanks, this is a very good find! Though, I am going to rework it so we don't block the UI thread, by polling in Screen::update() instead. |
|
@hrydgard Got it, in that case feel free to close this PR and replace it with the new rework :) |
|
Alright, closing in favor of #18736. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a type of #18694 caused by onResume()
It may or may not be exactly #18694 however since the original report noted that a full app restarted is needed, but on my end backing out of the
CwCheatScreenand going back in was enough to list cheats again on android 13, and this PR only makes it so onResume() does not break it in the first place