More readable methods std::string and fix repeat calling methods #19028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
requested changes
May 12, 2024
| @@ -58,7 +58,7 @@ enum class NoticeLevel { | |||
| class NoticeView : public UI::InertView { | |||
| public: | |||
| NoticeView(NoticeLevel level, std::string_view text, std::string_view detailsText, UI::LayoutParams *layoutParams = 0) | |||
| : InertView(layoutParams), level_(level), text_(text), detailsText_(detailsText), iconName_("") {} | |||
| : InertView(layoutParams), level_(level), text_(text), detailsText_(detailsText), iconName_() {} | |||
There was a problem hiding this comment.
can even skip iconName_ here, it defaults to empty
| @@ -406,15 +406,16 @@ class OpenGLContext : public DrawContext { | |||
| stencilWriteMask_ = writeMask; | |||
| stencilCompareMask_ = compareMask; | |||
| // Do we need to update on the fly here? | |||
| const auto depthStencil = curPipeline_->depthStencil; | |||
There was a problem hiding this comment.
I think whenever it's not too hard, let's be explicit about the type for these instead of using auto. Clearer and doesn't really take up a lot of code space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a good refactoring that doesn't break and reduces size code functions.