-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Feature: Ability to show Speed/VPS as quantity or percent. #2969
Conversation
cool,can u add a new commit to make the font size of the counter smaller[adjustable]?it covers a lot of the display if its set to 'both'. |
So many options :( Do people really care? |
as 4 me,i hate simple and love complex...so i like 2 have a lotta options... |
@hrydgard: http://forums.ppsspp.org/showthread.php?tid=5128 and some prior discussion of the issue: #2959 so yeah, a few people care..but if that speaks for most of the userbase, I dunno. |
Hope this will be added but my question is,why it was even changed to percentage,why would someone want to see percentage than at what speed a game is running. With percentage,I don't see a point to keep the Options=>Show FPS enabled(personal opinion) |
That's for Henrik to answer, not me, heh. |
Well, it is most correct as a percentage or a ratio (e.g. 1x or 5x.) Having it based on 60 (vblanks) doesn't make it any more "real" or "correct" than measuring the speed of your car in millimeters per second. 100% is unquestionably full speed. 60 is... just some number. -[Unknown] |
If I understand you correctly,using percentage shows the exact\real speed |
Isn't that what this option does? 60 is basically arbitrary. It could be based on hcount instead, and 17143.20 could mean 100%. It would be just as correct. -[Unknown] |
Yeah, but in the long run, is it really hurting anything at this point to have a checkbox that can keep everyone satisfied? Besides, doesn't every emulator quantify speed based off the system's vertical refresh rate? I don't see the issue here with letting people see what they want to see.. |
Will this be merged anytime soon? |
I hope it will be |
I'm thinking of making it like this instead: 25/30 fps That way it's obvious where the speed percentage is coming from, and you can see the current real FPS correctly. Expressing the speed as frames per second, like 60 for 100%, doesn't make much sense for 30fps games while my suggestion does. |
Which ever way you guys go with this, is there any chance we can shrink down the size of the font by a lot, or have an option to change the size, it takes up so much screen space currently and worst of all overlays on top of the actual game. In fact moving it into the window boarder would be a sweet way of doing it as well, some emulators do this already. Such as VBA-M. |
So you're basically going to ditch the internal FPS idea, @hrydgard? I've no objections to that. It'd make a lot more sense to show the game's real FPS. When turbo is held, would it still for example, show:
? Just curious. |
In my example, "30" is the internal FPS, and "25" is the actual FPS. So yeah, if the game is a 60fps game, it would show like that. If it's a 30fps game, it would be: Putting it in the title makes sense on Windows, yeah. I'll try to find time but it's not top of my list for 0.9 |
Sounds like a plan. Should I close this request then, or shall we keep it open as a to-do list sort of thing? |
Putting it in the title makes sense until you realize that the title bar already has the game's id and name in it already, so adding the those numbers would make it even more crowded. Also, the display of VPS/FPS numbers in top right corner of the screen makes perfect sense for full screen in game screenshots that you'd wish to take to demonstrate performance regressions etc. If you don't like it, you can always turn off the option, and or hide it. Also the display of those numbers in the title bar would also be pointless in full screen mode too. As for the ditching of a flat 60 for 100% speed, I can see where you guys are coming from with this idea, but how will it work for games with a variable internal FPS? E.g Metal Gear Solid Peace Walker (runs the gamut from 20 in game, 30 during those comic book cutscenes, all the way to 60 in the title screens), Danganronpa (60 at the main menus and 30 in game), and many others. |
The game titles could be truncated or removed. Or have it be something like this: PPSSPP v0.X.X-XXXX-g000000 100%(60/60FPS) - Your game name here
Nobody said it would be going away on the Windows port. It could be made into a separate toggle.
PPSSPP already calculates the internal FPS, so it shouldn't be any different once Henrik writes the new counter. |
Thanks for addressing my concerns, it seems like they were unfounded. I'm rather fond of the current arrangement. |
No prob; I'm fairly sure Henrik wouldn't not(pardon the double negative) have a greater plan in mind when it comes to UI design/redesign. |
Except that I do like it and don't want to turn it off? What actually makes little sense if having huge green text covering up game mini maps, health bars, and other important info that many games display in the top right corner. And thedax said pretty much everything else there is to say on the matter as well. |
Yes, it does get in the way, I'll concede that point to you. What's the alternative if you want the FPS/VPS display on the emulator screen when playing in full screen mode though? Can't have it both ways. |
The alternative would be the ability to select where to have it onscreen, whether it's via hard-coded corners(or perhaps ask for X/Y coordinates?), or the ability to click + drag/touch + drag it wherever you want, like an onscreen widget. |
Changed to a single line, now it's like:
(or
when holding throttle) :) |
With this new method,is it normal to show lower value when you use frame skipping? 0.8.1-1688 |
Yeah that's the point of a classic FPS measurement, to see how many frames are drawn in a second. Look at the speed % if you really need to know how fast the emulation is going. |
I like this new FPS counter you've done up, @hrydgard. I'll close this pullrq. |
Some users are unhappy with the new percentage-only display of Speed/VPS, so let's have an option to toggle between the quantity and the percentage. It shows percentage by default.
Old UI Option:
![Screenshot 1](https://camo.githubusercontent.com/b8ef5a5f43c8edbbfbfe231792e7a84ec1398199c1acd4e5ca1ddf3cbc07762b/68747470733a2f2f692e6d696e75732e636f6d2f695237783366356d416a386e392e6a7067)
NewUI Option:
![Screenshot 2](https://camo.githubusercontent.com/02920a27ef558412be33224c5fbba424bd9c856b5661ecb4a46c0a9e6d3f1dbc/68747470733a2f2f692e6d696e75732e636f6d2f69626439454573353074444a38562e6a7067)
VPS as quantity:
![Screenshot 3](https://camo.githubusercontent.com/35e3866b34f0dc3c77cbfa64e004fe26528ab597584563fee7bece3d71c8c8b2/68747470733a2f2f692e6d696e75732e636f6d2f6962756b67414951573958736a4b2e6a7067)
VPS as percentage:
![Screenshot 4](https://camo.githubusercontent.com/7693f928f7449ff9298e47e5a9683df9adb2e4b8fd5f404f0d3bf99a0732c994/68747470733a2f2f692e6d696e75732e636f6d2f69673664464a796846776d704b2e6a7067)
New Win32 menu:
![Screenshot 5](https://camo.githubusercontent.com/10e2487f01d5b72032265916d5ea6f23b11fcaf66d1c24d88b214305c08cde0c/68747470733a2f2f692e6d696e75732e636f6d2f694f30454c58553044416e756a2e706e67)