-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New UI : Add buffered rendering(2x) #3035
Conversation
On my DROID 3, i set the rendering mode to: None-Buffered So the graphics looks crisp and clean, will the 2x mode achieve the crisp and clean look. |
Yes , should be the same as non-buffered mode . |
Isn't this the same as the Windows 2xSSAA feature? Why use a separate option and UI for Android? Shouldn't they be the same? @adriandennis17, well, it entirely depends on your device's resolution, really. Non-buffered means this:
Buffered with 2x the dimensions means this:
They won't be exactly the same. -[Unknown] |
@unknownbrackets , just want to simplify it , so user selects one single option buffered rendering(2x) will do the job (Instead of selecting 'buffered rendering' and then select 'Anti-aliasing' ) . |
I always think they are the same :) In my case ,my mobile device is native 1920x1080 which is 4x of real PSP one However the speed of buffered rendering with anti-aliasing ON which is 960x544 is slower than the non-buffered one which is native , 1920x1080 . |
@unknownbrackets Ok i see, So is it possible to add an option for Android to select their native resolution I thought ppssp could autodetect it ? |
Drawing to 1920x1080 is not all that slow. However, having buffers of that size and copying that many pixels in addition to drawing is much slower. Of course, I'm sure an option could be implemented. -[Unknown] |
The resolution stuff needs a rethinking, on Windows we need to decouple window size and resolution, and on Android we need to offer more choices. Maybe can combine these two into one neat design. |
@hrydgard " more choices " for android, You can also throw in the option to change ratio and orientation i know changing from landscape to portrait has been disabled for now on android. |
About resolution, why don't make it more simple? e.g. Just render it in psp original resolution on a texture, then simply stretch it to fit any resolution of screen with bi-linear filterring and an option "Keep aspect", this approach losts the Hi-res feature, but makes things simple. Actually, not everyone like the Hi-res feature, since it has many graphic glitches and disunion. |
@SteveGuo that's exactly what we do in buffered rendering normally. Filtering is a separate option, it causes artifacts in some games of course. I was just comaring 2x vs. disabled. -[Unknown] |
@unknownbrackets ppsspp now filters on intermediate image other than the FINAL image, this causes artifacts. |
Well, the game can ask for filtering on a particular texture or etc. and we respect that when "linear filtering" is set to auto. Well, it does render to immediate larger buffers if you're using a larger resolution, that's true (not really filtering, just higher sampling/etc.) I always use 1x. You can force "linear filtering" to nearest to ignore what the game says. -[Unknown] |
Sorry for my unclear expression, |
I integrated the 'Button Scaling' in this single pull request to avoid less hassle. |
if we decouple those two,then wouldn't it b like pcsx2? |
@raven02 i don't see the rendering 2x or native rendering mode, Did the commits got merge..... |
I'm closing this one and will rewrite it bit better :) |
This is same as ant-aliasing option enabled , just bind it to buffered rendering option . Original buffered rendering will be renamed to buffered rendering(native)
I'm not going to do it for old UI , only for new one