Better Bezier Patch fix

[raven02]

Although it is still bit hackery and incorrect , at least show more correct in Jeanne d'Arc and show more stuff in God Eater Burst .

Meanwhile , Issue #3519, Issue #3490

[hrydgard]

if you're gonna use a static sized array like that but still respect ucount and vcount, you should make sure that ucount and vcount are not bigger than what can fit in the array.

[raven02]

I indeed want to size the array dynamically with respect to ucount and vcount however i don't know how to do it .It would be appreciated if few lines sample can be given to me for reference.

[hrydgard]

Easiest way would be this:

u16 *indices = new u16[ucount * vcount * 6];

And at the end of the function:

delete [] indices;

[raven02]

Thanks .Will rebase it with this change.

[raven02]

Rebase done and tested okay.

[unknownbrackets]

Can you make this an ERROR_LOG_REPORT? Sorry for nitpicking, it'd be useful to know if it happens.

Or, I can after this is merged.

-[Unknown]

[raven02]

Sure . Done.

[daniel229]

Great,Super Robot War OE almost perfect with this commit.
Just a remain bug here.

ppsspp

jpcsp

[raven02]

Yep, i just ran it and battle scene seems to be excellent now .If you want to get rid of that artifact , run in FB to memory mode and should be fine .

Buffered mode seems not to be not cleared that artifact somehow

[daniel229]

But with FB to memory mode it does not show video.

[raven02]

Ooo seems to be :)

[ufdada]

Tested with Pursuit Force and its sequel. It looks better but has a huge impact on framerate (now it´s nearly unplayable and a lot of stuttering)

[unknownbrackets]

We could probably use a static buffer. If you're using a compiler, a profile while it's slow would really help:
http://www.codersnotes.com/sleepy

-[Unknown]

[ufdada]

Thanks for the advice, where should i upload the capture?

[unknownbrackets]

Something like http://temp-share.com/ is lightweight.

-[Unknown]

[raven02]

May be i can try to create new buffer only when the ucount * vcount > existing one .

[unknownbrackets]

Could just use a static SimpleBuf<u16> or something, from #include "Common/MemoryUtil.h". It's what the texture cache uses for its growing aligned buffers.

-[Unknown]

[ufdada]

Thanks, here you are: http://temp-share.com/show/Pf3mg6tW2

[unknownbrackets]

So, of that profile, 36.8s were spent drawing beziers, out of 40.72s processing GE instructions. 90% is pretty significant.

However, allocation is less than 0.5s of that. Still good to optimize, but most of that time is spent flushing. Most of that time seems to be in your video driver and the vertex cache I think.

-[Unknown]

[Nezarn]

btw Orphis said in the forum that he will port\fix his spline\bezier code from jpcsp http://forums.ppsspp.org/showthread.php?tid=1705&pid=42508#pid42508

[raven02]

Yep, no worry .Ultimately those current beizer/spline code will be replaced by a more complete one .