Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle option "Disable Stencil Test" & "Always Depth Write" #3646

Merged
merged 2 commits into from Sep 9, 2013
Merged

Toggle option "Disable Stencil Test" & "Always Depth Write" #3646

merged 2 commits into from Sep 9, 2013

Conversation

raven02
Copy link
Contributor

@raven02 raven02 commented Sep 5, 2013

It is hack setting for this time being and we can remove it later when we've correct stencil and depth testing .

Option 1 : Disable Stencil Test
Tested with FF 4 CC #2018

Option 2 : Always Depth Write
Tested with Saint Seiya Omega #1808

@@ -293,6 +293,10 @@ void GameSettingsScreen::CreateViews() {
static const char *texFilters[] = { "Auto", "Nearest", "Linear", "Linear on FMV", };
graphicsSettings->Add(new PopupMultiChoice(&g_Config.iTexFiltering, gs->T("Texture Filter"), texFilters, 1, 4, gs, screenManager()));

graphicsSettings->Add(new ItemHeader(gs->T("Hack Setting")));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "Hacks" or "Hack Settings".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@VIRGINKLM
Copy link
Contributor

With that oportunity, do you think that Hack Settings could include somekind of a category that would have hacks that correct visual bugs on non Buffered Rendering as an attempt to improve quality and performance at cost of accuracy? Like let's say, game "X" has some missing textures with Buffered Rendering Off. While it is possible to fix it on non Buffered Rendering the fix might actualy do something that is not how it is properly done on a real PSP (so it is done in a hacky way) and might interfere with other games since it's not acurate emulation. By triggering that fix though while on non buffered rending it will fix it and it will require less resources to emulate/render.

hrydgard added a commit that referenced this pull request Sep 9, 2013
Toggle option "Disable Stencil Test" & "Always Depth Write"
@hrydgard hrydgard merged commit 74418c1 into hrydgard:master Sep 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants