New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 360 port #4716
Update 360 port #4716
Conversation
@@ -2062,7 +2067,7 @@ u32 sceIoIoctlAsync(u32 id, u32 cmd, u32 indataPtr, u32 inlen, u32 outdataPtr, u | |||
u32 sceIoGetFdList(u32 outAddr, int outSize, u32 fdNumAddr) { | |||
WARN_LOG(SCEIO, "sceIoGetFdList(%08x, %i, %08x)", outAddr, outSize, fdNumAddr); | |||
|
|||
PSPPointer<SceUID> out; | |||
PSPPointer<s32_le> out; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SceUID_le
-[Unknown]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a good catch ! 👍
Just a note that travis reports this broke Symbian. |
@@ -273,7 +290,13 @@ static bool Memory_TryBase(u8 *base, const MemoryView *views, int num_views, u32 | |||
*(view.out_ptr_low) = (u8*)((int)arena->memmap->Base() + view.virtual_address); | |||
arena->memmap->Commit(view.virtual_address & 0x3FFFFFFF, view.size); | |||
} | |||
*(view.out_ptr) = (u8*)((int)arena->memmap->Base() + view.virtual_address & 0x3FFFFFFF); | |||
*(view.out_ptr) = (u8*)((int)arena->memmap->Base() + view.virtual_address & 0x3FFFFFFF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line broke Symbian.
Missing semicolon.
Ready for merge? needs a quick rebase at least. |
Seem to work on windows. |
No need to remove it, just update native & PPSSPP once #4728 is accepted. |
ah nice :) thanks ! |
Not a problem. It broke Windows too, so this should fix Xbox as well I'd guess (it defines _WIN32, right?). |
yes it's ok :) |
Wipeout Pure hangs after the title screen with this pull request merged on Win64... |
I can bisect it later btw but not right now. |
ah bad ! i can check about it tomorrow :) |
it was "[core/MediaEndigne] endian fix for video" Wipeout Pure is working :) |
…tex cache enabled
Urgh, totally forgot about merging this. I'll deal with it soon. |
@Ced2911 fwiw, I did a quick rebase of this, but it doesn't compile cleanly anymore: Probably because of other changes since. So I cherry-picked out a bunch of commits in #5590, at least getting it closer. -[Unknown] |
Very cool looking, as I've never got the chance to see Xbox 360 source code before 😄! Quick question: How would one even install this on their Xbox 360? |
Did the rest of this ever get merged? Any changes still needed? |
As @Ced2911 is no longer working on this, and nobody has picked up the flag, I'm going to close. |
Sorry for the big pull request :s
I only tested the Windows with gles gpu