Prevent psmfplayer from loading too many mpeg frames at once #5002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It takes more time (slowing the start of the video), and gets us closer to overflowing buffers and stuff.
This way we definitely won't overfill it.
hrydgard
added a commit
that referenced
this pull request
Jan 4, 2014
Prevent psmfplayer from loading too many mpeg frames at once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4550 again. Before these changes, it fills the video buffer and discards audio data that doesn't fit. This worked before when audio data was immediately demuxed, but now that happens on first read.
Also, seems like psmfplayer doesn't bother selecting the proper video/audio streams, but I'm not sure...
Anyway, Naruto still works this way too.
Without the cap on adding too much data at once, there is a slight but noticeable pause after the first frame/audio samples, before the video continues playing. I left the cap generously high in case it affects compatibility, but this kills the pause for me.
-[Unknown]