Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert resampling changes #5551

Merged
merged 4 commits into from
Feb 24, 2014
Merged

Conversation

unknownbrackets
Copy link
Collaborator

I'm not really very interested in audio in general, but it seemed SAS was causing emulation bugs. Anyway, there are complaints (some of which I cannot reproduce or at least cannot hear), so let's just go back to nearest neighbor. Someone else can mess with it.

Fixes #5538, fixes #5550.

-[Unknown]

@hrydgard
Copy link
Owner

I'm against reverting it, overall the code is better than before. There's something subtle hiding in here though - I hear crackles in the "oooj" noise that loco rocos make when you join them, for example.

I am currently not all that available but will have more time in a week, and I'll take another look.

I don't feel that whatever glitches are in here are bad enough to be worth even a temporary revert until then, to be honest. Would be different if we had a big release coming up but we just did one so it won't be for a while.

@unknownbrackets
Copy link
Collaborator Author

Well, 3edebbf was not right because it reads ahead without using that sample later, so games like Final Fantasy Tactics that use lower grains (it uses 64) will lose correct pitch fast.

But I'm far from an audiophile, and as a rule I don't like messing with things when I can't really tell if it's right.

-[Unknown]

@solarmystic
Copy link
Contributor

This pull request also "resolves" #5548 (comment) and #5538 (comment)

Before (scratchy SFX):-
https://www.mediafire.com/?3t0cg9877bd3461

After (smoother SFX):-
https://www.mediafire.com/?kvyo795hcykqmdd

@hrydgard
Copy link
Owner

Okay, okay, temporary revert it is. I'll just resurrect this stuff as a starting point later.

hrydgard added a commit that referenced this pull request Feb 24, 2014
@hrydgard hrydgard merged commit 40d867f into hrydgard:master Feb 24, 2014
@unknownbrackets unknownbrackets deleted the sas-minor branch February 24, 2014 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants