Show game background during controller/keyboard game selection #6388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More seamless when we already have the icon, for example.
Still looks nicer this way.
If the icon/bg is not loaded yet, we'd lock and block for it to load anyway. This uses a separate (or possibly atomic) lock.
This won't affect touch UIs but it's a nice touch for controller based animation imho.
|
That's really neat! |
hrydgard
added a commit
that referenced
this pull request
Jun 22, 2014
Show game background during controller/keyboard game selection
|
This is really cool. Thanks @unknownbrackets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no useful way to do it for touch/click, but I think this is nicer when using a controller.
Also, prevents UI locks when the disk is slow (e.g. spinning up) reading iso data, reads PIC0 from PBPs (several PBPs indeed had PIC0 there.)
I actually think playing SND0 might be nice (#2585), but I'm not interested enough to do it. But I did at least add a flag to grab SND0 if anyone wants to.
-[Unknown]