Win32: Fix a minor fullscreen bug. #6651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the window is maximized before going fullscreen, the taskbar appears on top, which is not desirable. Also, apply the maximized state properly again after exiting, if the user had the window maximized.
|
Just in case..@vnctdj, can you make sure this still works with your multi-monitor setup? |
|
I have tested, no problem :) |
|
Thanks. |
|
For minor fixes like this in the future, should I just push directly, or should I stick with the same process I've done since the beginning? |
|
For single liners and similar that you are sure about, just push. |
hrydgard
added a commit
that referenced
this pull request
Aug 5, 2014
Win32: Fix a minor fullscreen bug.
|
Okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the window is maximized before going fullscreen, the taskbar appears on top after entering fullscreen, which is not desirable (well, at least to me).
Also, apply the maximized state properly again after exiting, if the user had the window maximized.
Fixes #6639.