Replace frame download in Photo Kano. #7458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added a commit
that referenced
this pull request
Feb 9, 2015
Replace frame download in Photo Kano.
|
The function is also seen in other five games,and not really help them,Is it better to hook on its caller like this? |
|
Possibly, although maybe that function also exists in the other games? And maybe it does help those other games somehow that you don't see in a quick test? |
|
Hard to tell,so just keep it until found out broken things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes black photo and saveicon in Photo Kano,see #7457
Here is the function.
https://cloud.githubusercontent.com/assets/3481559/6101807/a159fd9c-b065-11e4-8fd4-17586e4c37f0.png