Add a bit of a hack for smaller framebuf memcpys #7678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this doesn't false-positive in any other games. Helps Valkyrie Profile's battle entry effect.
hrydgard
added a commit
that referenced
this pull request
Apr 12, 2015
Add a bit of a hack for smaller framebuf memcpys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Valkyrie Profile, some framebuf data is downloaded in chunks of 512 bytes. We were rejecting this (misaligned copy, which might mean a copy of texture data outside the framebuf), so the effect was missing.
The effect is pretty common though, it's the blur that happens whenever you enter a battle.
Anyway, this causes a download when the first stride bytes of a line is read. The other three reads of the line won't trigger a download, but we download full lines anyway. I wish we knew the whole height ahead of time.
Hopefully this doesn't false-positive in any other games. I'm a bit worried that it's more likely to affect texture data right after a framebuffer we've mis-detected the height of. At first I added the same change for upload, but decided better of it for this reason (texture uploads.)
-[Unknown]