-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 5xBR and scaling to existing 4xHQ #8019
Conversation
Cool, but as is has these requirements, maybe we should simply add additional options to defaultshaders.ini to override settings to match? That would make it much easier to use - as it is now, most people use higher resolutions than 1x and use linear scaling so enabling this shader will not work correctly. I can add support for those setting overrides, but I'll do it after I've pushed out 1.1, which I am looking to do tomorrow. |
Nice idea, I tried to do it just now: Oh and good luck with 1.1, it seems "tomorrow" is lagging from some time. ~ ReleaseTradition=true ;o Edit: |
@LunaMoo Yes this is fine, add it to the pull request and I'll merge it. Nice work. |
@hrydgard done:3 |
Hm, I found one problem: Enabling it, then going back and starting another game causes it to not be enabled anymore? Apart from that it's great! |
Hmmm I think it's filtering doesn't get set, because resolution doesn't change? I would have to add the postShaderIsUpscalingFilter_ = shaderInfo->isUpscalingFilter; to another place like here https://github.com/hrydgard/ppsspp/blob/master/GPU/GLES/Framebuffer.cpp#L174 or maybe call resized_ on game change, which would be better? I guess the first one is more proper, it also works fine, so I'll add it:3. |
The first, I think - somewhere in FramebufferManager initialization? |
Oh resolution was affected too:| I'll change it again. Edit: |
It fully works now, but I set resized_ in FramebufferManager::Init() couldn't really find any other way, so hope it's fine. |
Add 5xBR and scaling to existing 4xHQ
A simple and fast variant of 5xBR, also changed 4xHQ to actually use outputresolution as it also is an upscaling shader, someone just forgot to set it.
This gives us 2 nicely working scaling postprocessing shaders, which was proposed alternative solution for #6280
Note: for upscaling to work properly, screen scaling filter has to be set to nearest and rendering resolution to native x1.
Note2: at least 5xBR is affected by #8016 I don't think it really affects many games through ~ at least among those which I tested for now it was only Monster Hunter series which 3D game anyway and Dai-2-Ji Super Robot Taisen, which is 2D meaning a good target for such shader, but the issue affects only some menus,
Note3: I have no clue about licenses, the 5xBR is licensed under GNU General Public License and can be published under v2 or higher, hope that's ok with PPSSPP.