Allocate memory better by @unknownbrackets #8043
Conversation
This allows other, small allocates to fit in these spaces, which happens in some games (like Gods Eater Burst.)
It's wrong now. Although the memory is still not being allocated exactly the same, it's much closer.
|
Yes, let's wait until after 1.1.1 (which I will probably release this weekend, the ARM64 bug that I have now fixed is pretty bad). |
|
Not sure why VS2012 don't raise crash :) |
|
FWIW I made some small tweaks on my branch: I think that to be accurate, we might want to identify the loaded sceAtrac module, and return the context pointers from there. They seem to live in user memory allocated with the module prx (e.g. in its data segment or whatever.) Also, I think they are in fixed places, e.g. id=3 will always be in the same place, even if I deallocate the atrac ID and then reallocate it. It's possible something might accidentally depend on this... -[Unknown] |
We already allocate modules now.
|
@unknownbrackets done |
| @@ -1697,27 +1699,19 @@ static u32 sceKernelLoadModule(const char *name, u32 flags, u32 optionAddr) | |||
| if (!module) { | |||
| if (magic == 0x46535000) { | |||
| ERROR_LOG(LOADER, "Game tried to load an SFO as a module. Go figure? Magic = %08x", magic); | |||
| return -1; | |||
| // TODO: What's actually going on here? | |||
There was a problem hiding this comment.
This is Tekken 6 and Soul Calibur being silly and loading all files in a directory as modules, including the SFO file that happens to sit around there, IIRC.
There was a problem hiding this comment.
Right but I don't believe that the error response on real firmware is -1. If it is it's probably at least for a larger class of error than just these magic bytes.
IIRC, I specifically tested an SFO and got a different response, but that different response breaks Tekken 6 or Soul Calibur or whatever it was.
-[Unknown]
|
OK, time to merge. |
Allocate memory better by @unknownbrackets
This pick in @unknownbrackets module branch add 1 crash fix
please note that this pull request also remove the cheat address hack for Gods Eater Burst
Fix #5638