Fix UI sliders #8178
Merged
Fix UI sliders #8178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now has a text input box. +/- buttons are on the next line so you can cursor along slider. And the units are optionally displayed. # Conflicts: # UI/GameSettingsScreen.cpp
…d units. # Conflicts: # UI/GameSettingsScreen.cpp
|
Thanks @CarlKenner , sorry for the delay in merging. Had to fix up a few little things, 2634f73 , but overall very nice. |
|
Nicely done. Sorry about the little things you had to fix. |
|
Right, that was #8189. Well, UI is important too, right? -[Unknown] |
|
I've been mostly working on prep for certain future graphics APIs, but that's also important :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI for integer and floating point sliders is currently broken:
Entering lots of numbers was necessary for VR, so I fixed those problems and improved all the slider popups.