Make logic ops flush on GLES #8219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing it to always say unknown weights since the +1 on weightCount.
So that we can control it centrally in GLES_GPU.
We have a backup plan for them now, so they need to flush. Fixes hrydgard#2917.
|
Oh. Sorry about that one - that only made any kind of sense back when we didn't even try to fake logic ops :( |
|
Not your fault at all, I just wish I'd found it before looking everywhere else, heh. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So yeah. They weren't flushing. Tore apart blending and the entire rendeirng pipeline to try to simulate the failure on desktop, finally realized it just wasn't even trying...
-[Unknown]