Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split SDLJoyButtonMap for MacOSX and linux. #8286

Merged
merged 2 commits into from
Dec 24, 2015

Conversation

chrisbrasington
Copy link
Contributor

Mapping in else statement was tested on linux with a X360 and wii-u pro controller. Furthering #8285

hrydgard, I'm not 100% on all your environment variables (WIN32, APPLE, LINUX), but I figured it made more sense to give APPLE its own section and let the else statement catch LINUX.

… was tested on linux with a X360 and wii-u pro controller
@hrydgard
Copy link
Owner

Oh, I didn't know we needed a third mapping, figured most platforms could use the Windows one, from eariler reports? But if you tested this one to work, I guess it's fine...

@chrisbrasington
Copy link
Contributor Author

There's a few quirks where the Windows mapping doesn't work for me. The "L2" and "R2" triggers... well they're not triggers on a wii-u pro controller , but buttons. And then I would still need to add a button. I think it's the extra HOME button that throws it off.

But yeah, in linux this works great for X360 and wiiu-pro. Especially the DPAD usage.

@hrydgard
Copy link
Owner

Just would be annoying to get into a situation where I merge one mapping, then someone else chimes in and says on their linux the mapping has to be different...

BTW if you look at the diff, the indentation is different for some reason. Would be nice to not introduce a difference...

@chrisbrasington
Copy link
Contributor Author

I hear you on that. I think the only important part really is supporting enough buttons, I don't care much what they're called.

Alright, fix indentation is part of this request.

@hrydgard
Copy link
Owner

Alright, let's see how this works for people...

hrydgard added a commit that referenced this pull request Dec 24, 2015
split SDLJoyButtonMap for MacOSX and linux.
@hrydgard hrydgard merged commit ff98e91 into hrydgard:master Dec 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants