New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
little changes #8410
little changes #8410
Conversation
preincrement used to be slightly faster for iterators on older C++ compilers, but it certainly doesn't make a difference on integer types, and I don't think it makes a difference any more at all anyway. So I'm not going to merge that part. |
okis, removed |
back 1 other little change, join 2 in 1
71ad9a1
to
53ac6d9
Compare
to avoid problem with compilations in forks... |
@hrydgard a little question, in this lines of Common/ArmEmitter.cpp:902
whats the posibility of the vars op or Rn or Rd take a negative value? |
@latot please buddy. Disable the travis irc bot when you enable travis on your fork |
@latot shouldn't happen really. Also as bigpet says, you need to look at your travis chatbot config.. |
mm, this is weird, i disabled the fork from travis D: its posible merge this now? or need others changes? |
@@ -1,5 +1,7 @@ | |||
# https://travis-ci.org | |||
|
|||
sudo: required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
travis do some changes the some year, the new proyect added after 2014, need include this line to works if it requieres root, in the proyect don't affects this but forks yes, and is very problematic when at least i try to make a pull request, any pr fails but if i do a change to can works with travis but that commit will be reflacted in the pr, finally i think its better inlcude it and simplify this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that was part of the whitelisting we got earlier, because it was before/around when they added the containers.
I suppose this isn't an issue, though.
-[Unknown]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mm, well its right don't is a issdue of the main proyects, but as we saw with all my failed commits (resync fork) in the irc affects the forks, anyway i only can opine about this, then remove or not?
next time i'll remove it directly, sorry the problems i'm very unsecure with that. |
Hi, well this would be greate if some one can check this please.