Improve performance on Raspberry Pi (and maybe other Linux) #8801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some variants, /tmp will be tmpfs, but not always. In case our mmap fails to prevent flushing to disk (as apparently happens on Raspberry Pi), shm will work better for us. Thanks go to klyoungblood.
|
Wow, that must have put some wear on those sd cards :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, our mmap() was actually flushing to disk on Raspberry Pi.
Thanks go to @klyoungblood:
http://forums.ppsspp.org/showthread.php?tid=18879&pid=118445#pid118445
Didn't use shm_open, since it doesn't work on iOS and seemed like the more troublesome route. At least this way, nothing should get worse / fail to start. Note that /dev/shm is mostly a Linux thing.
It might be good for someone to validate that disk flushes aren't happening on other platforms, like iOS. We don't need to worry about Android or Windows, which don't use this code.
-[Unknown]