Update changelog

CHANGELOG.md

@@ -3,7 +3,9 @@
 ## 0.4.0 - dev
 
 + Add option `-` to `mix recode` to read from stdin.
-+ Add `Recode.Task.UnusedVariable`
++ Add `Recode.Task.UnusedVariable`.
++ Update `Recode.Task.SinglePipe`. Some false positives are fixed.
++ Update `Recode.Task.PipeFunOne`. Some false positives are fixed.
 
 ## 0.3.0 - 2022/08/28
 

lib/recode/task/pipe_fun_one.ex

@@ -58,7 +58,11 @@ defmodule Recode.Task.PipeFunOne do
 
   defp pipe_fun_one(zipper, issues, _autocorrect), do: {zipper, issues}
 
-  defp issue?({:|>, _meta1, [_a, {_name, _meta2, args}]}), do: args == nil
+  defp issue?({:|>, _meta1, [_a, {_name, _meta2, nil}]}), do: true
+
+  defp issue?({:|>, _meta1, [_a, {_name, meta, []}]}), do: Keyword.get(meta, :no_parens, false)
+
+  defp issue?(_ast), do: false
 
   defp update({:|>, meta, [a, b]}) do
     {:|>, meta, [a, update(b)]}

lib/recode/task/single_pipe.ex

@@ -58,7 +58,7 @@ defmodule Recode.Task.SinglePipe do
     {skip(zipper), issues}
   end
 
-  defp single_pipe({{:|>, _meta, ast}, _zipper_meta} = zipper, issues, true) do
+  defp single_pipe({{:|>, _meta, _ast}, _zipper_meta} = zipper, issues, true) do
     zipper = zipper |> Zipper.update(&update/1) |> skip()
 
     {zipper, issues}

test/recode/task/pipe_fun_one_test.exs

@@ -61,6 +61,18 @@ defmodule Recode.Task.PipeFunOneTest do
       assert_issue(source, PipeFunOne)
     end
 
+    test "reports issue for single pipe" do
+      code = """
+      def foo(arg) do
+        arg |> IO.inspect
+      end
+      """
+
+      source = run(code, autocorrect: false)
+
+      assert_issue(source, PipeFunOne)
+    end
+
     test "reports no issue" do
       code = """
       def foo(arg) do