-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
article: add "Prevent layout shifts with CSS grid stacks" #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
(Ooops, I hit the "approve" button when I should not have yet 😶 )
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great article and there are not too many important changes to be made (you can tell because of how @judu and I both took the time to bother with small details but I know that's what you want and expect 😆)
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very important
Sweet sweet technique! Hadn't thought of using grid this way and I'll definitely keep it in mind.
Important
- I can't remember seeing "superpose" (and variations) used in English. I'd switch to use "stack" and "stacking" to name this technique because that's the vocabulary used in CSS.
- Is
visibility: hidden
enough to hide from assistive technologies?
Nitpicks
- There are a few occurences of "simple", "not that hard" or difficulty level. I don't have a reference at hand but it's recommended to avoid that language. What is "simple" for someone might not be for someone else and it's usually extra words with no importance.
- The CSS seems to not be syntax highlighted.
I've suggested a few English changes but overall, I've refrained myself from trying to change the tone/style of the article.
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
the CSS article is quite a good and interesting read. I only found the additional '&' in the text. No additional comments on changes. English is not my first language, and I have to say that your writing style is easy to read. That's great! I also like the ratio between text, code and images. Keep the style of your blog posts this way... |
Dear @urcadox @judu @rik @rdmueller OK, I just read the whole thing an took annotations on my document. As Keanu says it, YOUR ARE BREATHTAKING!!! [insert keanu.gif (but not animated for @rik) here] 😉 |
❤️
That's great feedback, I'll change that.
TBH, I haven't looked into this much. I just spent some time reading and asking and seems like
Yes, you're right. I read the same recommandations. I try to follow those when I write documentation. If I understood correctly the reasons, you really don't want to explain X by saying "just do X" or "simply do X". When I used those words in the article I asked myself "is it a problem?". I thought it was ok because I tried to tell my own experience and for me it was simple. In the end, the confusion is here, people can't know for sure what I meant so I'll rephrase those. Thanks a lot 👍
Yeah, I'm not sure if it's just prismjs or the GitHub them I chose.
👍 |
Thanks
👍
That's great to hear, thx 🤗 |
@rik Nice ;-) Yesterday I gathered the feedbacks (I'll work on them soon) and I started the other article, the "I have a blog now". I may ping you again, thanks for everything. |
I like the styling / theme of the blog. Stuff is visible and it looks fresh. Good job |
I learnt stuff, and you did a great job at explaining issues you had I wouldn't even have thought about (super cool use of the gif). That's a cool read, and you're showing a really nice trick I have some comments, most are extremely minor. It's a good article :). Nice start of the blog, following! |
The "styling/theme" is from 2017, I want to change it but it will still be simple and I'll work on this after the first articles...
Thanks, force HTTPS is enabled on production.
Yep, others mention that, I plan to describe this at the beginning.
Interesting...
😆
Ah yes, I haven't thought about that.
👍 I need to check that again, you're right.
Thanks a lot for your time and feedbacks 👍 |
overlay? |
@mere-teresa Seems like @rik is right as "stack/stacking" seem to be the official CSS term for this 😉 Thanks for having a look ❤️ |
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
pages/css-grid-superposition--qcj5jo/css-grid-superposition--qcj5jo.md
Outdated
Show resolved
Hide resolved
You're welcome. And yep, I did a long review. I hope it helps, even many others reviewers were there before me. |
@mere-teresa It helps a lot 😍 thank you so much. Now I need to compile all those and take some time to rework this... |
d38d098
to
6d74765
Compare
473a6c2
to
447f566
Compare
ce80864
to
d946d19
Compare
d946d19
to
60d0bf2
Compare
Preview here