Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

article: add "Prevent layout shifts with CSS grid stacks" #7

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

hsablonniere
Copy link
Owner

@hsablonniere hsablonniere commented Sep 7, 2020

Preview here

  • Final review
  • hititipi byte range
  • share on twitter
  • share on linkedin
  • share on reddit /css /webdev
  • share on some slack
  • share on some discord
  • cross post on medium
  • cross post on dev.to

Copy link

@judu judu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

(Ooops, I hit the "approve" button when I should not have yet 😶 )

Copy link
Contributor

@urcadox urcadox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great article and there are not too many important changes to be made (you can tell because of how @judu and I both took the time to bother with small details but I know that's what you want and expect 😆)

Copy link

@rik rik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very important

Sweet sweet technique! Hadn't thought of using grid this way and I'll definitely keep it in mind.

Important

  • I can't remember seeing "superpose" (and variations) used in English. I'd switch to use "stack" and "stacking" to name this technique because that's the vocabulary used in CSS.
  • Is visibility: hidden enough to hide from assistive technologies?

Nitpicks

  • There are a few occurences of "simple", "not that hard" or difficulty level. I don't have a reference at hand but it's recommended to avoid that language. What is "simple" for someone might not be for someone else and it's usually extra words with no importance.
  • The CSS seems to not be syntax highlighted.

I've suggested a few English changes but overall, I've refrained myself from trying to change the tone/style of the article.

@rdmueller
Copy link

the CSS article is quite a good and interesting read.

I only found the additional '&' in the text. No additional comments on changes.

English is not my first language, and I have to say that your writing style is easy to read. That's great!

I also like the ratio between text, code and images.

Keep the style of your blog posts this way...

@hsablonniere
Copy link
Owner Author

Dear @urcadox @judu @rik @rdmueller

OK, I just read the whole thing an took annotations on my document.
Your feedbacks are just awesome, you took some of your time for me and for this, you have my gratitude, probably a free drink if we see each other IRL and a mention at the end.

As Keanu says it, YOUR ARE BREATHTAKING!!! [insert keanu.gif (but not animated for @rik) here] 😉

@hsablonniere
Copy link
Owner Author

hsablonniere commented Sep 8, 2020

@rik

Sweet sweet technique! Hadn't thought of using grid this way and I'll definitely keep it in mind.

❤️

I can't remember seeing "superpose" (and variations) used in English. I'd switch to use "stack" and "stacking" to name this technique because that's the vocabulary used in CSS.

That's great feedback, I'll change that.

Is visibility: hidden enough to hide from assistive technologies?

TBH, I haven't looked into this much. I just spent some time reading and asking and seems like v:h will be hidden for screen readers but maybe a aria-hidden="true" could also help. I should test.

There are a few occurences of "simple", "not that hard" or difficulty level. I don't have a reference at hand but it's recommended to avoid that language. What is "simple" for someone might not be for someone else and it's usually extra words with no importance.

Yes, you're right. I read the same recommandations. I try to follow those when I write documentation. If I understood correctly the reasons, you really don't want to explain X by saying "just do X" or "simply do X". When I used those words in the article I asked myself "is it a problem?". I thought it was ok because I tried to tell my own experience and for me it was simple. In the end, the confusion is here, people can't know for sure what I meant so I'll rephrase those. Thanks a lot 👍

The CSS seems to not be syntax highlighted.

Yeah, I'm not sure if it's just prismjs or the GitHub them I chose.

I've suggested a few English changes but overall, I've refrained myself from trying to change the tone/style of the article.

👍

@hsablonniere
Copy link
Owner Author

@rdmueller

the CSS article is quite a good and interesting read.

Thanks

I only found the additional '&' in the text. No additional comments on changes.

👍

English is not my first language, and I have to say that your writing style is easy to read. That's great!
I also like the ratio between text, code and images.
Keep the style of your blog posts this way...

That's great to hear, thx 🤗

@rik
Copy link

rik commented Sep 8, 2020

You're breathtaking!

I'm happy to use GIFs when the platform does not support videos 😉

Feel free to ping again if you want another round of feedbacks (does the preview auto-update?).

@hsablonniere
Copy link
Owner Author

@rik Nice ;-)

Yesterday I gathered the feedbacks (I'll work on them soon) and I started the other article, the "I have a blog now". I may ping you again, thanks for everything.

@jlengrand
Copy link

I like the styling / theme of the blog. Stuff is visible and it looks fresh. Good job

@jlengrand
Copy link

image

Not sure how it's gonna look after publication, but

@jlengrand
Copy link

  • So, I'm a backender. You might want to define (or maybe link to a definition of) layout shift and grid superposition (even if you come back to it in the article. Or at least mention you ll define those :)).

  • You're French like me : You use many commas. The rest of the world tends to do a whole lot less of that :). Usually, commas can be divided into shorter sentences.

  • No referral link for Clever Cloud ? 😎 :trollface:

  • You might want to add captions for your images? (cool that you have nice alt text already)

  • Try to reduce the amount of tense you have in your article (there s past, present and future as well as conditional in there altogether).

I learnt stuff, and you did a great job at explaining issues you had I wouldn't even have thought about (super cool use of the gif). That's a cool read, and you're showing a really nice trick

I have some comments, most are extremely minor. It's a good article :). Nice start of the blog, following!

@hsablonniere
Copy link
Owner Author

I like the styling / theme of the blog. Stuff is visible and it looks fresh. Good job

The "styling/theme" is from 2017, I want to change it but it will still be simple and I'll work on this after the first articles...

Not sure how it's gonna look after publication, but

Thanks, force HTTPS is enabled on production.

Capture d’écran_2020-09-09_17-00-02

So, I'm a backender. You might want to define (or maybe link to a definition of) layout shift and grid superposition (even if you come back to it in the article. Or at least mention you ll define those :)).

Yep, others mention that, I plan to describe this at the beginning.

You're French like me : You use many commas. The rest of the world tends to do a whole lot less of that :). Usually, commas can be divided into shorter sentences.

Interesting...

No referral link for Clever Cloud ? sunglasses :trollface:

😆

You might want to add captions for your images? (cool that you have nice alt text already)

Ah yes, I haven't thought about that.

Try to reduce the amount of tense you have in your article (there s past, present and future as well as conditional in there altogether).

👍 I need to check that again, you're right.

I learnt stuff, and you did a great job at explaining issues you had I wouldn't even have thought about (super cool use of the gif). That's a cool read, and you're showing a really nice trick

I have some comments, most are extremely minor. It's a good article :). Nice start of the blog, following!

Thanks a lot for your time and feedbacks 👍

@mere-teresa
Copy link

* superpose

overlay?

@hsablonniere
Copy link
Owner Author

@mere-teresa Seems like @rik is right as "stack/stacking" seem to be the official CSS term for this 😉

Thanks for having a look ❤️

@mere-teresa
Copy link

@mere-teresa Seems like @rik is right as "stack/stacking" seem to be the official CSS term for this 😉

Thanks for having a look ❤️

You're welcome. And yep, I did a long review. I hope it helps, even many others reviewers were there before me.

@hsablonniere
Copy link
Owner Author

@mere-teresa It helps a lot 😍 thank you so much. Now I need to compile all those and take some time to rework this...

@hsablonniere hsablonniere force-pushed the first-articles branch 5 times, most recently from d38d098 to 6d74765 Compare October 10, 2020 16:51
@hsablonniere hsablonniere force-pushed the first-articles branch 3 times, most recently from 473a6c2 to 447f566 Compare October 18, 2020 22:40
@hsablonniere hsablonniere changed the title First articles article: add "Prevent layout shifts with CSS grid stacks" Oct 18, 2020
@hsablonniere hsablonniere force-pushed the first-articles branch 3 times, most recently from ce80864 to d946d19 Compare October 24, 2020 01:05
@hsablonniere hsablonniere merged commit 472dfd8 into master Oct 27, 2020
@hsablonniere hsablonniere deleted the first-articles branch October 27, 2020 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants