-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from setup.py
to pyproject.toml
#398
Move from setup.py
to pyproject.toml
#398
Conversation
Currently, only a few features from
In the case of 1), I wasn't sure that it was necessary due to the new @hsahovic - if you think any of the changes are undesirable, I'd love to discuss with you. I'm assigning this over to you now. |
Thanks @cameronangliss! I'll run some tests with this new setup this week and let you know if anything needs to be changed. |
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 88.43% 88.48% +0.05%
==========================================
Files 38 38
Lines 3648 3648
==========================================
+ Hits 3226 3228 +2
+ Misses 422 420 -2 |
Thanks @cameronangliss ! |
This PR brings
poke-env
from usingsetup.py
to usingpyproject.toml
, which is the modern way to describe how package installation proceeds. It's generally easier to read, removes the need forMANIFEST.in
, and primes us in the future for configuring tools such as isort and passing stub files to allowpoke-env
importers to have all the type information from all imported classes/functions (when we get around to fully typing all of those out).I also added the
flake8
line-length
limit to theblack
configuration in thepyproject.toml
file.I've tested from this branch locally, and poke-env
pip install
s perfectly for me.