Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features in composition should be encoded as json not string #1398

Closed
raitisbe opened this issue Dec 17, 2020 · 0 comments · Fixed by #1762
Closed

Features in composition should be encoded as json not string #1398

raitisbe opened this issue Dec 17, 2020 · 0 comments · Fixed by #1762
Assignees
@raitisbe
Labels
bug documentation performance Performance issues
Milestone
4.0

Comments

@raitisbe
Copy link
Collaborator

raitisbe commented Dec 17, 2020 •
edited

See how they are encoded right now: https://hub.lesprojekt.cz/statusmanager/?request=load&id=3967889c-6762-49e6-b0d3-a42288d8116f

That would require also to change composition schema to support both ways of encoding "object" and "string". Reading features should also be backwards compatible.
@raitisbe raitisbe added this to the Future milestone Dec 17, 2020
@raitisbe raitisbe self-assigned this Jan 22, 2021
raitisbe added a commit that referenced this issue Apr 22, 2021
@raitisbe
fix: Encode features as Json object instead of string
da12e61 
This is needed when saving/loading compositions because storing as string is inneficient, needs
parsing, adds escape characters and makes harder to read.

fix #1398
@raitisbe raitisbe mentioned this issue Apr 22, 2021
Merged
raitisbe added a commit that referenced this issue Apr 22, 2021
@raitisbe
fix: Encode features as Json object instead of string
315e56a 
This is needed when saving/loading compositions because storing as string is inneficient, needs
parsing, adds escape characters and makes harder to read.

fix #1398
@jmacura jmacura modified the milestones: Future, 4.0 Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raitisbe raitisbe

Labels
bug documentation performance Performance issues
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

fix: Encode features as Json object instead of string hslayers/hslayers-ng
2 participants
@raitisbe @jmacura