Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS is affecting parent page #445

Closed
bvj opened this issue Jan 6, 2020 · 7 comments
Closed

CSS is affecting parent page #445

bvj opened this issue Jan 6, 2020 · 7 comments
Assignees
@raitisbe
Labels
bug

Comments

@bvj
Copy link
Contributor

bvj commented Jan 6, 2020

Example - in PrestaShop are menu styles in conflict (app.css from line 52).
It would be good to use hslayers CSS only for hslayers elements.
@jmacura jmacura added the bug label Jan 6, 2020
@raitisbe
Copy link
Collaborator

raitisbe commented Jan 6, 2020

An option would be to contain all hslayers css in some container class ".hslng" for example
and write in all css rules
.hslng .menu ...
.hslng .lm-title {...

Did you notice any more classes except .menu? Menu seems to be a realy bad name for a css class.

raitisbe added a commit that referenced this issue Jan 6, 2020
@raitisbe
Remove .menu css class selector
11efbb0 
refs #445
@raitisbe raitisbe self-assigned this Jan 6, 2020
@bvj
Copy link
Contributor Author

bvj commented Jan 6, 2020

noticed only the menu class, but for the future will be good solution your container class option

@jmacura
Copy link
Collaborator

jmacura commented Jan 7, 2020

Or maybe use 'hs-' prefix for every CSS class, as with the IDs here: #408 ?

@bvj
Copy link
Contributor Author

bvj commented Jan 7, 2020

Sounds good

@raitisbe
Copy link
Collaborator

raitisbe commented Jan 8, 2020

Yes, prefixing is better. Because it protects from external css messing up hsl css, and not just other direction.

@raitisbe
Copy link
Collaborator

raitisbe commented Jan 8, 2020

Also we should use ids less, because they wont work correctly when we have multiple hsl maps in the same page

raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
Prefix content-wrapper and change to class
5b61e83 
refs #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
Prefix content-wrapper and change to class
b11cba8 
refs #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
Map div should not be with unique id
71abbfb 
refs #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
Css to get rid of element IDs and prefix with hs-
8da0683 
refs #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
refs #445
e6b7c96
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
refs #445
b9afc65
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
Make panelplace and dialog-area into property in layoutService
be1a29e 
ref #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
hs-minisidebar should be a class not id
7a8c147 
refs #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
sidebar-list class should be hs-sidebar-list
68c3b2b 
refs #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
Remove a lot of duplicate id=ows_type for various elements
0202abc 
ref #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
map-container element renamed to hs-map-container
217ab99 
refs #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
infopanel element renamed to gs-infopanel class
14ed1ae 
refs #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
Make panelplace and dialog-area into property in layoutService
4de52db 
ref #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
hs-minisidebar should be a class not id
09e3461 
refs #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
sidebar-list class should be hs-sidebar-list
2b7a058 
refs #445
raitisbe added a commit that referenced this issue Jan 8, 2020
@raitisbe
Remove a lot of duplicate id=ows_type for various elements
6e1cc27 
ref #445
FilipLeitner pushed a commit that referenced this issue Jan 9, 2020
@raitisbe @FilipLeitner
CSS conflicting with parent
d01f193 
Map div should not be with unique id
refs #445

Css to get rid of element IDs and prefix with hs-
refs #445

map-container element renamed to hs-map-container
refs #445

infopanel element renamed to gs-infopanel class
refs #445

Make panelplace and dialog-area into property in layoutService
ref #445

Wait for map to load before adding geolocation controls

hs-minisidebar should be a class not id
refs #445

sidebar-list class should be hs-sidebar-list
refs #445

Remove a lot of duplicate id=ows_type for various elements
ref #445

hs-page-wrapper is a class not id

Add hs preposition to element selection in panelSpaceHeight function

Fix service name typo in vgi-draw component location->layout

Fix sidebar width on mobile

refactor layoutService.SidebarBottom function

Fix closed sidebar width on mobile
raitisbe added a commit that referenced this issue Jan 9, 2020
@raitisbe
CSS conflicting with parent (#456)
3449055 
Map div should not be with unique id
refs #445

Css to get rid of element IDs and prefix with hs-
refs #445

map-container element renamed to hs-map-container
refs #445

infopanel element renamed to gs-infopanel class
refs #445

Make panelplace and dialog-area into property in layoutService
ref #445

Wait for map to load before adding geolocation controls

hs-minisidebar should be a class not id
refs #445

sidebar-list class should be hs-sidebar-list
refs #445

Remove a lot of duplicate id=ows_type for various elements
ref #445

hs-page-wrapper is a class not id

Add hs preposition to element selection in panelSpaceHeight function

Fix service name typo in vgi-draw component location->layout

Fix sidebar width on mobile

refactor layoutService.SidebarBottom function

Fix closed sidebar width on mobile
raitisbe added a commit that referenced this issue Jan 26, 2020
@raitisbe
Dont use getElementById to get dialog area element
91ab1bd 
refs #445
raitisbe added a commit that referenced this issue Jan 26, 2020
@raitisbe
Add missing injections of layoutService
5eff25c 
refs #445
raitisbe added a commit that referenced this issue Jan 26, 2020
@raitisbe
Prefix content-wrapper and change to class
8511478 
refs #445
raitisbe added a commit that referenced this issue Jan 26, 2020
@raitisbe
CSS conflicting with parent (#456)
5d6d808 
Map div should not be with unique id
refs #445

Css to get rid of element IDs and prefix with hs-
refs #445

map-container element renamed to hs-map-container
refs #445

infopanel element renamed to gs-infopanel class
refs #445

Make panelplace and dialog-area into property in layoutService
ref #445

Wait for map to load before adding geolocation controls

hs-minisidebar should be a class not id
refs #445

sidebar-list class should be hs-sidebar-list
refs #445

Remove a lot of duplicate id=ows_type for various elements
ref #445

hs-page-wrapper is a class not id

Add hs preposition to element selection in panelSpaceHeight function

Fix service name typo in vgi-draw component location->layout

Fix sidebar width on mobile

refactor layoutService.SidebarBottom function

Fix closed sidebar width on mobile
raitisbe added a commit that referenced this issue Jan 26, 2020
@raitisbe
Dont use getElementById to get dialog area element
e65a355 
refs #445
raitisbe added a commit that referenced this issue Jan 26, 2020
@raitisbe
Add missing injections of layoutService
a5f99b5 
refs #445
@raitisbe
Copy link
Collaborator

raitisbe commented Feb 3, 2020

Prefix possible conflicting css classes with 'hs' for embedding in hslayers in CMSes.

raitisbe added a commit that referenced this issue Feb 3, 2020
@raitisbe
Rename mainpanel class to hs-main-panel
5d2ea4e 
ref #445
raitisbe added a commit that referenced this issue Feb 3, 2020
@raitisbe
Reduce usage of element IDs
87ff2ad 
ref #445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raitisbe raitisbe

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@raitisbe @jmacura @bvj