styler: QML upload, base64 encoded SVG icons #5008
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilipLeitner
commented
Jun 18, 2024
| this.qml = styleString; | ||
| this.qml = styleString.replace( | ||
| /base64:/g, | ||
| 'data:image/svg+xml;base64,', |
There was a problem hiding this comment.
This is to be fixed. Its not right to assume all base64 would be SVG icon.
- we should problably do this for SLDs as well
There was a problem hiding this comment.
QMLs will include source attribute on both Option (new fromat) and prop (necessary backwards comaptiblity) elements containing base64. It can be then used to adjust the value as needed.
For now we will parse via prop as Geostyler still takes the value from that attribute. See 02e923f
Prioritise style type when loading from file
Move base64 icon fix to separate function and file
jmacura
reviewed
Jun 24, 2024
Apply suggestions from code review Co-authored-by: jmacura <jmacura@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow usage of base64 encoded SVG icons provided via QML*
*expected to include data type in source attribute of options and prop element
Related issues or pull requests
closes #4996
Pull request type
Please check the type of change your PR introduces:
Do you introduce a breaking change?
Checklist
npm testlocally)