Intorduce generalized versions of Assertion and assertFailure
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sol
reviewed
Mar 16, 2017
src/Test/HUnit/Lang.hs
Outdated
| HasCallStack => | ||
| String -- ^ A message that is displayed with the assertion failure | ||
| -> Assertion' a | ||
| assertFailure' msg = msg `deepseq` E.throwIO (HUnitFailure location $ Reason msg) |
There was a problem hiding this comment.
I would prefer to change the type of assertFailure instead of introducing a new primitive.
There was a problem hiding this comment.
Do you want me to change the type Assertion too or do you want to keep the the old Assertion and make assertFailure Assertion' a ?
There was a problem hiding this comment.
Keep Assertion, remove Assertion' and just use IO a for assertFailure.
|
@osa1 sorry for the late reply, btw. |
|
Tests were failing. I fixed that and pushed to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17.