This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Fixed following scenarios not returning HTTP Error 503 while Jersey s… #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this yet - I will update this PR with a small fix of a bug it introduces :) |
|
The tests are really hard to understand. Could you clean them up a little bit, e.g by splitting stuff out into methods with speakable names. |
|
Yes, I agree I will do so. |
…hould not be ready anymore to service requests and may lead to exceptions: 1) While the Jersey servlet is being destroyed and a request is incoming 2) When a resource is removed, but Jersey is not yet republished, if a request comes that would get routed to this resource this will lead to exceptions instead of a 503 as expected. 3) Changed Jersey init/reload logic to be around Jersey's WebComponent reference Signed-off-by: IVAN GEORGIEV ILIEV <ivan.iliev@musala.com>
|
Updated the PR, fixed a bug that was present due to it, modified the tests hopefully are now more readable, they are also more stabled as I fixed some problems in the concurrency logic in them. |
|
Just to mention this PR should resolve bugs like this one -> #135 |
|
thanks, will check it soon |
|
Well I totally forgot about this PR :D I think you did too? Any word on when you can take a look? |
|
@hstaudacher Any chance to merge this and include it in an upcoming release? |
guidfort
added a commit
to guidfort/osgi-jax-rs-connector
that referenced
this pull request
Sep 28, 2018
Bugfix: see Pull Requests "hstaudacher#147" hstaudacher#147 "Fixed following scenarios not returning HTTP Error 503 while Jersey s…"
guidfort
added a commit
to guidfort/osgi-jax-rs-connector
that referenced
this pull request
Sep 28, 2018
Bugfix: see Pull Requests "hstaudacher#147" hstaudacher#147 "Fixed following scenarios not returning HTTP Error 503 while Jersey s…"
guidfort
added a commit
to guidfort/osgi-jax-rs-connector
that referenced
this pull request
Sep 28, 2018
Bugfix: see Pull Requests "hstaudacher#147" hstaudacher#147 "Fixed following scenarios not returning HTTP Error 503 while Jersey s…"
guidfort
added a commit
to guidfort/osgi-jax-rs-connector
that referenced
this pull request
Sep 28, 2018
Bugfix: see Pull Requests "hstaudacher#147" hstaudacher#147 "Fixed following scenarios not returning HTTP Error 503 while Jersey s…"
guidfort
added a commit
to guidfort/osgi-jax-rs-connector
that referenced
this pull request
Oct 1, 2018
Bugfix: see Pull Requests "hstaudacher#147" hstaudacher#147 "Fixed following scenarios not returning HTTP Error 503 while Jersey s…" Switch to Version 5.3.2
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hould not be ready anymore to service requests and may lead to exceptions:
Signed-off-by: IVAN GEORGIEV ILIEV ivan.iliev@musala.com