-
Notifications
You must be signed in to change notification settings - Fork 98
Fixed following scenarios not returning HTTP Error 503 while Jersey s… #147
Conversation
Don't merge this yet - I will update this PR with a small fix of a bug it introduces :) |
The tests are really hard to understand. Could you clean them up a little bit, e.g by splitting stuff out into methods with speakable names. |
Yes, I agree I will do so. |
…hould not be ready anymore to service requests and may lead to exceptions: 1) While the Jersey servlet is being destroyed and a request is incoming 2) When a resource is removed, but Jersey is not yet republished, if a request comes that would get routed to this resource this will lead to exceptions instead of a 503 as expected. 3) Changed Jersey init/reload logic to be around Jersey's WebComponent reference Signed-off-by: IVAN GEORGIEV ILIEV <ivan.iliev@musala.com>
Updated the PR, fixed a bug that was present due to it, modified the tests hopefully are now more readable, they are also more stabled as I fixed some problems in the concurrency logic in them. |
Just to mention this PR should resolve bugs like this one -> #135 |
thanks, will check it soon |
Well I totally forgot about this PR :D I think you did too? Any word on when you can take a look? |
@hstaudacher Any chance to merge this and include it in an upcoming release? |
Bugfix: see Pull Requests "hstaudacher#147" hstaudacher#147 "Fixed following scenarios not returning HTTP Error 503 while Jersey s…"
Bugfix: see Pull Requests "hstaudacher#147" hstaudacher#147 "Fixed following scenarios not returning HTTP Error 503 while Jersey s…"
Bugfix: see Pull Requests "hstaudacher#147" hstaudacher#147 "Fixed following scenarios not returning HTTP Error 503 while Jersey s…"
Bugfix: see Pull Requests "hstaudacher#147" hstaudacher#147 "Fixed following scenarios not returning HTTP Error 503 while Jersey s…"
Bugfix: see Pull Requests "hstaudacher#147" hstaudacher#147 "Fixed following scenarios not returning HTTP Error 503 while Jersey s…" Switch to Version 5.3.2
…hould not be ready anymore to service requests and may lead to exceptions:
Signed-off-by: IVAN GEORGIEV ILIEV ivan.iliev@musala.com