Skip to content

Commit

Permalink
Merge "remove max_memory parameter in vblob" into services-r10
Browse files Browse the repository at this point in the history
  • Loading branch information
SonicWang authored and Gerrit Code Review committed Mar 27, 2012
2 parents d2af5cf + d3fb525 commit c5d3a2d
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion vblob/bin/vblob_node
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class VCAP::Services::VBlob::NodeBin < VCAP::Services::Base::NodeBin
options[:vblobd_log_dir] = parse_property(config, "vblobd_log_dir", String)
options[:vblobd_path] = parse_property(config, "vblobd_path", String)
options[:vblobd_auth] = parse_property(config, "vblobd_auth", String)
options[:max_memory] = parse_property(config, "max_memory", Integer)
options
end

Expand Down
1 change: 0 additions & 1 deletion vblob/config/vblob_node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ logging:
level: debug
vblobd_log_dir: /var/vcap/sys/service-log/vblob
pid: /var/vcap/sys/run/vblob_node.pid
max_memory: 128
node_id: vblob_node_free_1
nodejs_path: node
vblobd_path: /var/vcap/packages/vblob
Expand Down
3 changes: 0 additions & 3 deletions vblob/lib/vblob_service/vblob_node.rb
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ def initialize(options)
@vblobd_log_dir = options[:vblobd_log_dir]
@vblobd_auth = options[:vblobd_auth] || "basic" #default is basic auth

@max_memory = options[:max_memory]

@config_template = ERB.new(File.read(options[:config_template]))

Expand Down Expand Up @@ -210,7 +209,6 @@ def provision(plan, credential = nil)
provisioned_service = ProvisionedService.new
provisioned_service.name = name
provisioned_service.port = port
provisioned_service.memory = @max_memory
provisioned_service.keyid = username
provisioned_service.secretid = password
provisioned_service.pid = start_instance(provisioned_service)
Expand Down Expand Up @@ -366,7 +364,6 @@ def get_healthz(instance)

def start_instance(provisioned_service)
@logger.debug("Starting instance: #{provisioned_service.pretty_inspect}")
memory = @max_memory
pid = fork
if pid
@logger.debug("Service #{provisioned_service.name} started with pid #{pid}")
Expand Down
1 change: 0 additions & 1 deletion vblob/spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ def get_node_config()
:mbus => parse_property(config, "mbus", String),
:config_template => vblob_conf_template,
:port_range => parse_property(config, "port_range", Range),
:max_memory => parse_property(config, "max_memory", Integer),
:base_dir => '/tmp/vblob/instances',
:local_db => 'sqlite3:/tmp/vblob/vblob_node.db'
}
Expand Down

0 comments on commit c5d3a2d

Please sign in to comment.