New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-export-config creates invalid configuration file #679
Comments
@AnrDaemon thanks for this issue... In a quick test using multiple values like
This is a bug! The code -
will output the first line above, obviously with a The code will fall down to -
which will now generate the 2nd line with no name, so we get just If you add 3 values ``--new-blocklevel-tags "b1 b2 b3"`, then you will get 3 lines, etc...
I would expect
So we are definitely in need of a fix for this service... Comments, patches, PR very welcome... thanks... |
There's two more issues. |
@AnrDaemon yes, thanks for pointing out the additional items... The Actually the full code and comment is - buf[i++] = '-'; /* Make sure any escaped Unicode is terminated */
buf[i] = 0; /* so valid class names are generated after */
/* Tidy appends last digits. */
SetOptionValue( doc, option->id, buf ); One wonders about the need for this addition... there is already a value validator, But this setter would automatically add a 5th Either the Also why is there no value output for It seems there must be another There exists a Finally there may be another A config of
So unless that order is corrected the following will fail
This would show up this different order bug, that would remain even when the output is fixed, unless something is done about reversing the output order at the same time... So there are certainly a number of bugs here in this As stated comments, patches, PR very welcome... I too will experiment... thanks... |
@AnrDaemon this intrigued me, so I went on to create an The full diff is commit ea4ae0d So I built a First there was no change in the Regression tests, but this just means maybe there is no tests that tests this output, but it is still a good thing... Then I ran -
and there were no differences... Some relevant output in the
This is a first cut It would be appreciated if users could checkout the |
Commit bb7c494 adds display of
As indicated, this does not seem a problem... Also it is noted The only test remaining is to setup and try say Look forward to any other user tests of this |
Concerning
Now when you set the prefix like
Maybe this looks better, but now that I have removed this auto addition of the
So what about the strange case mention in the source code comment, namely
But on the other hand this modified tidy 5.7.3.I679 is not wrong with -
AND the HTML generated with the likes of Passing the output through the validator pointed out another small thing, that tidy generates a
But will leave that as a separate issue... In summary, as far as I can tell the removal of the auto addition of a At the moment, unless I think of something else to try, or others have a suggestion, this concludes my testing of this As stated, look forward to any other user tests of this |
According to https://drafts.csswg.org/css-syntax-3/#tokenization (if I read it correctly), the parser is right. So, no surprize here. |
PR #695 created... |
@AnrDaemon this fix is now in |
HTML Tidy 5.6 (windows build)
Sample output
The text was updated successfully, but these errors were encountered: