Allow opening read-only files (e.g. system binaries)

[danimo]

No description provided.

[radare]

Imho opening in rw should be an option. Not enforced at all by default, like in r2

…

On 3 Jul 2017, at 17:09, Daniel Molkentin ***@***.***> wrote: You can view, comment on, or merge this pull request online at: #196 Commit Summary Allow opening read-only files (e.g. system binaries) File Changes M src/optionsdialog.cpp (5) Patch Links: https://github.com/hteso/iaito/pull/196.patch https://github.com/hteso/iaito/pull/196.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[danimo]

and by "opening r/w", you mean opening a temporary copy?

[danimo]

Anyway, my primary scratch was that opening a read-only file currently fails hard. If the r2 API provides for a solution already, I'm happy to use that instead.

[radare]

no. open the file itself as rw

…

On 3 Jul 2017, at 17:26, Daniel Molkentin ***@***.***> wrote: and by "opening r/w", you mean opening a temporary copy? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#196 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-lrI2SCWGscYdV05dn1-2EDVroMDCks5sKQgYgaJpZM4OMZ-N>.

[danimo]

how? if I try to open something in /usr/bin that I do not have write access to, the open call with rw flags will fail.

[radare]

if you want to edit that file do it as root or make a copy to your home before doing that. but making silent copies of files is confusing, and iaito by itself doesnt have any feature to modify the binary so there’s no sense in opening the files as rw

…

On 3 Jul 2017, at 17:32, Daniel Molkentin ***@***.***> wrote: how? if I try to open something in /usr/bin that I do not have write access to, the open call with rw flags will fail. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#196 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-lieFmmCaguRWwdH0n9XdL_nztxteks5sKQl0gaJpZM4OMZ-N>.

[danimo]

Somehow there's a misunderstanding about this patch: I didn't want to edit the file, just look at it. However, without this patch, iaito will silently fail to open a file that it cannot write to. I did not want to edit the file. You were the one to bring up the option to open those files rw :)

[trufae]

no, there’s no misunderstanding, the patch is clear. what its not clear is WHY iaito was opening the files as rw because its a read-only tool

…

On 3 Jul 2017, at 17:37, Daniel Molkentin ***@***.***> wrote: Somehow there's a misunderstanding about this patch: I didn't want to edit the file, just look at it. However, without this patch, iaito will silently fail to open a file that it cannot write to. I did not want to edit the file. You were the one to bring up the option to open those files rw :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#196 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGIjGzrqN6aTK_ivxpJbxpNE0lOnjfI_ks5sKQqggaJpZM4OMZ-N>.

[radare]

well, lets merge this but thats not correct, because iaito should open in readonly by default and add a combobox in the open dialog to choose rw mode