Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge VectorFileSensor, VectorFileEffector to FileIORegion #306

Open
breznak opened this issue Mar 5, 2019 · 3 comments
Open

Merge VectorFileSensor, VectorFileEffector to FileIORegion #306

breznak opened this issue Mar 5, 2019 · 3 comments

Comments

@breznak
Copy link
Member

breznak commented Mar 5, 2019

As the current names are a bit confusing, and merging the 2 would share quite a lot of common code (both need to check for the file, ...)

Sensor = reader, Effector = writer.

The simplified usage would be

Region rIn = FileIORegion("region1", "read", "path/myFile.txt");
...
Region rOut = FileIORegion("region3, "write", "output.csv");

I'm not sure how much API-breaking would be removing the 2 classes and merging the functionality to 1, but we could provide wrappers to keep the old API.

@dkeeney
Copy link

dkeeney commented Mar 5, 2019

I like the idea of changing the name. FileIORegion is much more understandable.

Combining them would be ok I guess. When compute( ) is called...which operation is performed? A read or a write. I guess it could depend on how the file is opened.

Fairly low priority I would think.

@breznak
Copy link
Member Author

breznak commented Mar 5, 2019

When compute( ) is called...which operation is performed? A read or a write. I guess it could depend on how the file is opened.

In a constructor param, indicating input/output type. In the example "read", "write"

@breznak breznak added the low label Mar 5, 2019
@breznak
Copy link
Member Author

breznak commented Mar 5, 2019

Before, with this issue comes cleanup of VectorFile itself #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants