Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cereal for TMRegion #421

Closed
wants to merge 9 commits into from
Closed

Cereal for TMRegion #421

wants to merge 9 commits into from

Conversation

dkeeney
Copy link

@dkeeney dkeeney commented Apr 20, 2019

This covers Cereal serialization for TMRegion.

It is pending on #419

@dkeeney dkeeney self-assigned this Apr 20, 2019
@dkeeney
Copy link
Author

dkeeney commented May 13, 2019

@breznak, @ctrl-z-9000-times,
I am going to take a few days off, drive up to Oregon and visit some relatives. It's great being retired and I can just take time off whenever I feel I need a break.

I pushed what I have for this PR. After PR #422 is pushed to master this should build as well. I will try to do this before I leave.

Lets see...other things on my plate:

@breznak
Copy link
Member

breznak commented May 13, 2019

drive up to Oregon and visit some relatives.

enjoy the road-trip and have a great time!

create PyPI entry. #19

it's almost half of the year, I think we should slowly be prioritizing the python 2 obsoletion, ie merging new py code and making sure it works, continued work on the bindings (and their testing), ...

@ctrl-z-9000-times
Copy link
Collaborator

Have a nice trip!

breznak
breznak requested changes May 14, 2019
View reviewed changes
Copy link
Member

@breznak breznak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a broken merge with Connections & TM changes, otherwise the serialization looks good. Thank you

src/nupic/algorithms/Connections.cpp Outdated
@@ -557,42 +557,6 @@ void Connections::bumpSegment(const Segment segment, const Permanence delta) {
}


void Connections::destroyMinPermanenceSynapses(
const Segment segment, Int nDestroy,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is some mistake, was added by #446

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..all the connections changes seem out of place. try git checkout -- master src/nupic/..../Connections.*

@dkeeney
Copy link
Author

dkeeney commented May 14, 2019

This branch is really messed up. Don't know what happened.
I am going to start over with a clean branch....I have a few minutes before we leave.

@dkeeney dkeeney closed this May 14, 2019
@dkeeney dkeeney deleted the cereal-TMRegion branch May 14, 2019 15:49
@dkeeney dkeeney mentioned this pull request May 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breznak breznak breznak requested changes

Assignees

@dkeeney dkeeney

Labels
in_progress NetworkAPI serializable TM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dkeeney @breznak @ctrl-z-9000-times