Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace APR libraries with std:: libraries (abandoned) #74

Closed
dkeeney opened this issue Aug 30, 2018 · 8 comments
Closed

Replace APR libraries with std:: libraries (abandoned) #74

dkeeney opened this issue Aug 30, 2018 · 8 comments
Assignees

Comments

@dkeeney
Copy link

dkeeney commented Aug 30, 2018

Another placeholder for things to do.
Delete the APR library dependency and see what breaks. Fix it by replacing it with calls to std:: libraries.
In the OS folder the Directories and Path objects can be implemented with #include filesystem . This of course requires switching to C++17.

Edit: part of #47

@breznak
Copy link
Member

breznak commented Aug 30, 2018

After the capnp, I'd like to set for another advanture and bring c++17 (update CI, MSVC for Win,..) and then we can drop lots of dependencies

@breznak breznak mentioned this issue Sep 19, 2018
5 tasks
@dkeeney
Copy link
Author

dkeeney commented Sep 19, 2018

Ok, I will start in on this.
But first I want to start over with a fresh clone of htm-community/nupic.cpp

@breznak
Copy link
Member

breznak commented Sep 19, 2018

But first I want to start over with a fresh clone of htm-community/nupic.cpp

Or you can clone numenta/nupic.core (1st level clone) so you can make PRs to both easily

@dkeeney
Copy link
Author

dkeeney commented Sep 19, 2018 via email

@dkeeney
Copy link
Author

dkeeney commented Sep 19, 2018 via email

@breznak
Copy link
Member

breznak commented Sep 19, 2018

I don't want to accidentally change anything in numenta/nupic.core.

don't worry, wouldn't happen. One thing is to clone something, other are push privileges.
Clone of nupic.cpp is ok as well (y)

I haven't found the branch, nor clone of project, in your profile yet. So when you're ready, please open a PR.

@dkeeney dkeeney changed the title Replace APR libraries with std:: libraries Replace APR libraries with std:: libraries (abandoned) Nov 5, 2018
@dkeeney
Copy link
Author

dkeeney commented Nov 5, 2018

This PR is abandoned. I was taking this in too large of chunks. And in the process of trying to get MinGW to work, ended up with massive white-space changes that were mostly Just line-ending changes but it made compares almost impossible.

So, See Roadmap Issue #81 for how I propose we proceed.

@breznak
Copy link
Member

breznak commented Nov 7, 2018

Closing, reopen if needed

@breznak breznak closed this as completed Nov 7, 2018
@breznak breznak added this to the Dependencies_redux milestone Nov 12, 2018
@dkeeney dkeeney mentioned this issue Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants