Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for upcoming FastBoot 1.0 breaking changes #34

Merged
merged 2 commits into from Jun 17, 2017

Conversation

simonihmig
Copy link
Contributor

process.env.EMBER_CLI_FASTBOOT will be gone in FastBoot 1.0. This should now work in pre and post 1.0 versions of ember-cli-fastboot. See ember-fastboot/ember-cli-fastboot#360 for context.

Also includes some ES6 code style cleanup...

@RobbieTheWagner
Copy link
Member

Hi @simonihmig I'm confused, how does fastboot know to ignore importing it now?

@simonihmig
Copy link
Contributor Author

It does not. That's why there is this guard now to not run browser stuff in FastBoot: https://github.com/html-next/ember-hammertime/pull/34/files#diff-168726dbe96b3ce427e7fedce31bb0bcR32

For FastBoot 1.0 there will be just one build, not two separate like now (browser + FastBoot). So all browser JS will also be part of the FastBoot app, so we have to use guards. Here is some more context: https://gist.github.com/kratiahuja/fd073007e10abb9db0a2ec42bc1d7c17

I guess there will be some official blog post some time soon explaining the future changes, but I wanted to prepare things in advance, at least for those addons I need in my FastBoot app...

@RobbieTheWagner
Copy link
Member

@simonihmig I just hit these issues myself, so I am going to merge this. After looking at the changes, it appears this is only compatible with the new fastboot standards right? Isn't there something else we need to do to make sure it works with both the old beta standards and the new rc standards?

@RobbieTheWagner RobbieTheWagner merged commit 4f4d097 into html-next:master Jun 17, 2017
@simonihmig
Copy link
Contributor Author

@rwwagner90 Thanks for merging. I actually see no reason why this should not work with the older beta versions of FastBoot as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants