Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new config generator #117

Merged
merged 41 commits into from
Mar 27, 2021
Merged

feat: add new config generator #117

merged 41 commits into from
Mar 27, 2021

Conversation

gildesmarais
Copy link
Member

@gildesmarais gildesmarais commented Mar 11, 2021 •
edited
Loading

  • allow choosing the extractor in selector questions
  • reuse html2rss' extractors for that, default to Html2rss::ItemExtractors::DEFAULT
  • improve architecture (begs for elm style arch)
  • add rspec integration test
  • style text appearance on cli
  • check with reek

Closes #94.

@gildesmarais
feat: add new config generator
70f8456 
spec helper

fix dirname gsub regexp

.

channel question

remove template_gen_config

items selector selector, print beautified html of item

channel + item selector

more callbacks

use method hooks

.

order requires

.

refactor method name

.

.

.

.
@gildesmarais
happier rubocop
93ab532
@gildesmarais
spec and readme
744c7a8
@gildesmarais gildesmarais self-assigned this Mar 11, 2021
@gildesmarais gildesmarais mentioned this pull request Mar 12, 2021
Merged
@gildesmarais
Copy link
Member Author

This definitely needs a separation of 'data' and 'view'. piotrmurach/tty-prompt looks like a good fit for the view.

gildesmarais
gildesmarais commented Mar 24, 2021
View reviewed changes
Copy link
Member Author

@gildesmarais gildesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round

Gemfile Outdated Show resolved Hide resolved
html2rss-configs.gemspec Outdated Show resolved Hide resolved
lib/html2rss/configs/generator.rb Outdated Show resolved Hide resolved
lib/html2rss/configs/generator/file_creator.rb Outdated Show resolved Hide resolved
lib/html2rss/configs/generator/file_creator.rb Outdated Show resolved Hide resolved
@gildesmarais gildesmarais merged commit 2754e9f into master Mar 27, 2021
@gildesmarais gildesmarais deleted the feat/generator branch March 27, 2021 22:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gildesmarais gildesmarais

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve the config generator
1 participant
@gildesmarais