Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.htmlhintrc silently ignored if not valid JSON #662

Closed
estrehle opened this issue Jun 30, 2021 · 2 comments · Fixed by #893
Closed

.htmlhintrc silently ignored if not valid JSON #662

estrehle opened this issue Jun 30, 2021 · 2 comments · Fixed by #893
Labels
keep-unstale The issue will not be marked as stale by the stale-bot

Comments

@estrehle
Copy link

If the .htmlhintrc is not valid JSON, the linter silently ignores it and uses a default config.

For example, I had made the mistake of keeping a trailing comma:

{
    "attr-lowercase": false,
}

The default config has "attr-lowerclase": true and I received a lot of unwanted errors. It took me a while to figure out that the malformatted JSON was the culprit.

It would be helpful if the linter at least displayed a warning log message upon execution if it cannot parse the config file.

@coliff coliff changed the title .htmlhintrc silently ignored if not valid JSON .htmlhintrc silently ignored if not valid JSON Jun 30, 2021
@marwinburesch
Copy link

I agree, for example the docs use single quotes in the examples, but it is only valid with double quotes

@stale
Copy link

stale bot commented Sep 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Sep 19, 2021
@stale stale bot closed this as completed Oct 3, 2021
@thedaviddias thedaviddias added keep-unstale The issue will not be marked as stale by the stale-bot and removed bot:stale Issue marked as stale because there was no activity labels Oct 23, 2021
@thedaviddias thedaviddias reopened this Oct 23, 2021
is2ei added a commit to is2ei/HTMLHint that referenced this issue Jan 30, 2022
is2ei added a commit to is2ei/HTMLHint that referenced this issue Jan 30, 2022
is2ei added a commit to is2ei/HTMLHint that referenced this issue Jan 30, 2022
is2ei added a commit to is2ei/HTMLHint that referenced this issue Jan 30, 2022
is2ei added a commit to is2ei/HTMLHint that referenced this issue Jan 30, 2022
is2ei added a commit to is2ei/HTMLHint that referenced this issue Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-unstale The issue will not be marked as stale by the stale-bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants