refactor: Convert most CommonJS-style import/exports to ESM #1368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Mixed import/export style makes things a bit more difficult to read because they have mixed semantics. Additionally, the "module style" is compiled down to CommonJS anyways, so there is no practical difference.
This also simplifies the unecessary verbosity of the type imports and
require
near the top ofhtmlhint.ts
, since we do away with those CommonJS imports.Proposed changes:
This converts all CommonJS modules in
src/
that are able to be convered to static ECMAScript imports (no dynamic import).