arrow keys broken in vim mode

[ryenus]

The arrow keys probably should always work regardless the vim mode is on or off.

[Ckath]

they're not so much 'broken' as they are swapped to with the old h j k l keybinds:

htop/ScreenManager.c

Lines 195 to 205 in f79591e

	case 'h': ch = KEY_LEFT; break;
	case 'j': ch = KEY_DOWN; break;
	case 'k': ch = KEY_UP; break;
	case 'l': ch = KEY_RIGHT; break;
	case KEY_LEFT: ch = 'h'; break;
	case KEY_DOWN: ch = 'j'; break;
	case KEY_UP: ch = 'k'; break;
	case KEY_RIGHT: ch = 'l'; break;
	case 'K': ch = 'k'; break;
	case 'J': ch = 'K'; break;
	case 'L': ch = 'l'; break;

it isnt perfect but I also wouldnt be sure what better solution there is for this. the forks that added vim binds all handled this in a different way.

that said, we could sacrifice the old functionality of H and K. since those just toggle settings you can change anyway, they're not critical. this would mean you can have the regular arrow keys still work in vim mode, and the old functionality of hjkl would be on HJKL when vim mode is enabled.

[ryenus]

this would mean you can have the regular arrow keys still work in vim mode...

@Ckath yeah, would love to have that, the other thing is that currently with vim mode on, the hjkl keys only works in the main screen, but in sub-screens like the list of file handles (L), and environment variables (e), hjkl do not work, and one still need to use the arrows keys. Possible to have the vim keys also work there?

[Ckath]

Possible to have the vim keys also work there?

yeah as from what I can see nothing colides with hjkl movements in the panel code, so it's trivial to make hkjl work there as well. it'll be regardless of vimmode because I cant get to the settings from within the panel code. but I dont think thats a big issue here.

I'll throw together a quick fix that does the arrow keys and adds hjkl for panels like environment vars and openfiles

[natoscott]

See @Ckath notes in: #37