New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor vim bind improvements #106

Closed

Ckath wants to merge 2 commits into htop-dev:master from Ckath:vimmode_arrows

Contributor

Ckath commented Sep 8, 2020

this addresses two things mainly:

keep arrow keys working in vim mode
allow hjkl movement in panels (open files, environment vars, etc)

the arrow keys are restored in vimmode by dropping H and K keys when vimmode is on and simply remapping HJKL to hjkl directly without the need to ruin arrow keys. hjkl movement in panels is simply added regardless of vimmode, as this doesnt collide with anything here and in the existing codebase it isnt trivial to access the settings from within panel.c

this would fix #69

Ckath added 2 commits

September 2, 2020 17:15


          redo vimmode keybind mapping

75d4730

- keep arrow keys working inside vimmode
- drop 'H' and 'K' binds in favor of logical 'hjkl' remaps


          allow hjkl for movement in panels

05431a6

natoscott added a commit that referenced this pull request


          Revert the vim_mode setting for now, needs a rethink

c9ecd0f

There have been too many bugs reported in vim_mode, and
the proposed fixes are increasingly fragile - hence we
have decided to back it out for now.  For reference:

   #69
   #37
   #106

The whitespace changes also arrived in commit 12805f6
not sure what that was about, but backed out as well.

cgzones added needs-discussion 🤔 needs-rebase labels

Member

natoscott commented Sep 15, 2020

See also: #37

natoscott closed this

ryenus pushed a commit to ryenus/htop that referenced this pull request


          re-enable vim mode as a short term solution

758d353

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus added a commit to ryenus/htop that referenced this pull request


          merge vim-mode support as a short term solution

a8da0ae

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* using there being 3 keys in the function bar as detection for 'prompt'
* add comment to clarify prompt detection
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus pushed a commit to ryenus/htop that referenced this pull request


          re-enable vim mode as a short term solution

6b6a358

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus added a commit to ryenus/htop that referenced this pull request


          merge vim-mode support as a short term solution

3b0e312

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* using there being 3 keys in the function bar as detection for 'prompt'
* add comment to clarify prompt detection
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus pushed a commit to ryenus/htop that referenced this pull request


          re-enable vim mode as a short term solution

9a1ccc6

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus added a commit to ryenus/htop that referenced this pull request


          merge vim-mode support as a short term solution

5ef0421

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* using there being 3 keys in the function bar as detection for 'prompt'
* add comment to clarify prompt detection
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus pushed a commit to ryenus/htop that referenced this pull request


          re-enable vim mode as a short term solution

97fb9c0

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus added a commit to ryenus/htop that referenced this pull request


          merge vim-mode support as a short term solution

81bc7d7

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* using there being 3 keys in the function bar as detection for 'prompt'
* add comment to clarify prompt detection
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus pushed a commit to ryenus/htop that referenced this pull request


          re-enable vim mode as a short term solution

0fb9d08

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus added a commit to ryenus/htop that referenced this pull request


          merge vim-mode support as a short term solution

afd1b97

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* using there being 3 keys in the function bar as detection for 'prompt'
* add comment to clarify prompt detection
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus pushed a commit to ryenus/htop that referenced this pull request


          re-enable vim mode as a short term solution

441f831

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus added a commit to ryenus/htop that referenced this pull request


          merge vim-mode support as a short term solution

89305a0

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* using there being 3 keys in the function bar as detection for 'prompt'
* add comment to clarify prompt detection
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus pushed a commit to ryenus/htop that referenced this pull request


          re-enable vim mode as a short term solution

65e820e

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus added a commit to ryenus/htop that referenced this pull request


          merge vim-mode support as a short term solution

9bb984c

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* using there being 3 keys in the function bar as detection for 'prompt'
* add comment to clarify prompt detection
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus pushed a commit to ryenus/htop that referenced this pull request


          re-enable vim mode as a short term solution

737346b

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

ryenus added a commit to ryenus/htop that referenced this pull request


          merge vim-mode support as a short term solution

cb21abc

This is the work done by ckath <ckat@teknik.io>, from the unmerged
pull request htop-dev#106

* Revert "Revert the vim_mode setting for now, needs a rethink"
*  - This reverts commit c9ecd0f.
*
* ignore vimmode in prompts
* using there being 3 keys in the function bar as detection for 'prompt'
* add comment to clarify prompt detection
* redo vimmode keybind mapping
* - keep arrow keys working inside vimmode
* - drop 'H' and 'K' binds in favor of logical 'hjkl' remaps
* allow hjkl for movement in panels

BenBE mentioned this pull request

Ability to remap keys or enable Vim-mode #638

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment