Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #72

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Fix CI #72

merged 3 commits into from
Nov 22, 2023

Conversation

gl-eb
Copy link

@gl-eb gl-eb commented Nov 10, 2023

This is a draft PR to test possible fixes to the manybuild_linux jobs.

@gl-eb
Copy link
Author

gl-eb commented Nov 10, 2023

The ci workflow does not work on pull requests because GITHUB_REPO points to htseq/htseq but the PR branch is on a fork, e.g. gl-eb/htseq.
actions/checkout should take care of this, but v4 does not work because it depends on node20. Thus v3 should be the way to go. Currently the next issue are the file system paths for the build

@gl-eb
Copy link
Author

gl-eb commented Nov 10, 2023

Using the actions/checkout@v3 with path: htseq turns out to be a drop-in replacement for the previous cloning steps. All subsequent steps can remain the same.

@gl-eb gl-eb closed this Nov 10, 2023
@gl-eb gl-eb reopened this Nov 10, 2023
@gl-eb gl-eb marked this pull request as ready for review November 10, 2023 12:07
@gl-eb
Copy link
Author

gl-eb commented Nov 22, 2023

Sorry to ping you gain @iosonofabio. The changes to CI in this PR should hopefully put an end to the failed checks seen in other PRs. Should you be happy with them and merge the PR, I can rebase #72 to include the changes.

Also sorry for the messy history of force pushing. The commit history is clean at least.

@iosonofabio
Copy link
Collaborator

Thanks for pinging. I'll review hopefully before EoW

@iosonofabio iosonofabio merged commit c111d90 into htseq:main Nov 22, 2023
15 checks passed
@gl-eb gl-eb deleted the ci branch November 23, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants