Clean up java testing #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add TestSuites to call the associated JUnit tests
removed failing assertion for onComplete being called as Decoder never calls it
no assertions in test, not clear on purpose but leaving for the moment
ptaoussanis
pushed a commit
that referenced
this pull request
Feb 2, 2018
|
This seems like a really uncontroversial change - is there something preventing a merge that is not reflected in this PR? |
|
Ah, I see. This was merged after (I suspect) being rebased, and therefore git sees the merged commits as different commits (since they change hashes, that is factually correct). This PR should be closed since the diffs it represents are already applied to the code. |
|
Merging manually, thanks Glen! 👍 Sorry for the delay getting this in. |
ptaoussanis
pushed a commit
that referenced
this pull request
Apr 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing of java code requires some tidy up, this is a baby step towards that, bringing junit testing to the Rakefile