Added useful tip with local addresses #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to remember your local IP.
Add useful tip with local addresses on start
|
lgtm at first glace. I will double check over the weekend and (likely) merge this in as is. |
|
Looks like it's going to repeat its predecessor's fate which had awaited 1 year 3 month and 7 days to be |
| @@ -98,6 +101,16 @@ function listen(port) { | |||
| + ' on: '.yellow | |||
| + (protocol + '//' + host + ':' + port).cyan); | |||
|
|
|||
| log('\nAvailable on:'.yellow); | |||
|
|
|||
| for (var dev in ifaces) { | |||
There was a problem hiding this comment.
Do not use for in loops.
There was a problem hiding this comment.
Use Object.keys(ifaces).forEach(function (dev) { instead.
|
Some comments for you. |
| log('\nAvailable on:'.yellow); | ||
|
|
||
| for (var dev in ifaces) { | ||
| ifaces[dev].forEach(function(details){ |
There was a problem hiding this comment.
Conform to style here: ifaces[dev].forEach(function (details) {
|
Are there still any chances of merging or at least adding such a simple function? I'm just curious, nothing personal. 😇 |
|
Whoops. Didn't get emails for your new commits. In the future comment after committing and I'll be sure to merge it faster. |
indexzero
added a commit
that referenced
this pull request
Jun 8, 2015
Added useful tip with local addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added useful tip with local addresses not to run
ifconfigcommand every time you want to recall your local IP.Once again 😉 #60