Adds --hide-dotfiles option #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,3 @@ | |||
| set ts=2 | |||
| set sw=2 | |||
| set expandtab | |||
There was a problem hiding this comment.
Please do not include your personal dotfiles in this PR.
|
Thank you for your contribution. I had a few minor comments. This seems like a reasonable feature, but I am going to wait to merge it until there are +1s from the community of |
|
👍 for this |
johntron
force-pushed
the
feature/dotfiles-visibility
branch
2 times, most recently
from
52b6c57
to
3f27aa2
Compare
johntron
force-pushed
the
feature/dotfiles-visibility
branch
from
3f27aa2
to
76f4e8f
Compare
|
👍 I want to keep .git-folders in the structure without exposing them. Surprised this feature wasn't available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooks up ecstatic's
showDotfilesoption - allows users to hide files beginning with a dot (.). Required updating ecstatic to 1.3.1.I've also written a test, but wasn't able to run existing tests, so haven't committed.