Open browser with URL provided in -o [path] #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoncharov85
changed the title
|
Would you mind squashing your commits? |
|
The commits were squashed. It's very safe change. |
|
I added logger info for url it's opening. There is some discussion going on in #260. Please check it as well. |
This was referenced Mar 31, 2016
Closed
craigmichaelmartin
added a commit
to craigmichaelmartin/http-server
that referenced
this pull request
Apr 6, 2016
Closes http-party#231 Addresses PRs http-party#234, http-party#250, and http-party#260
Closed
|
Closing in favor of #250 due to the simpler style |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#231 Fix to use url in -o [path]