Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'secure: false' to http proxy #371

Closed
wants to merge 1 commit into from

Conversation

tamascsaba
Copy link

@tamascsaba tamascsaba commented May 25, 2017

I use https proxy with self signed cert.

Fixes #214

@BigBlueHat
Copy link
Member

How do we handle the scenario when not using a self signed cert? This change would effectively mean you could never proxy a secure endpoint securely.

Thoughts?

@BigBlueHat
Copy link
Member

Sure. But there are situations where you do want to verify them. Perhaps this should be configurable via an --proxy-insecure param?

@bdefore
Copy link

bdefore commented Oct 25, 2017

Thanks @tamascsaba this resolved an issue I had where I was receiving an error of Error: Hostname/IP doesn't match certificate's altnames due to it not matching the domain it was supplied for. Certs shouldn't have this issue, but we are transition and need this workaround for development purposes.

I agree with @BigBlueHat that this should have a new flag rather than override by default. Another implementation of this is here: #236

@thornjad
Copy link
Member

I'm going to close this for now in favor of the flag-based approaches in #236 and #459

@thornjad thornjad closed this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https certificate error when proxying to server with self-signed certificate
4 participants