Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm package-lock #403

Merged
merged 2 commits into from Aug 8, 2018
Merged

Add npm package-lock #403

merged 2 commits into from Aug 8, 2018

Conversation

thornjad
Copy link
Member

This adds package-lock.json which will help prevent future dependency problems. From the npm documentation:

This file describes an exact, and more importantly reproducible node_modules tree. Once it's present, any future installation will base its work off this file, instead of recalculating dependency versions off package.json.

@indexzero
Copy link
Collaborator

Should we be publishing package-lock.json files? If http-server is used as a dependency instead of a global CLI tool wouldn't this complicate the install tree?

@thornjad
Copy link
Member Author

If published, it would definitely end up complicating the install tree of anything using it as a dependency. However, part of the beauty of package-lock.json is that it can't be published. When publishing, npm will simply ignore it. It's designed for use in the source code only, i.e. here on GitHub.

@thornjad
Copy link
Member Author

thornjad commented Dec 9, 2017

Using a package-lock.json ensures that everyone who works with this source code will be using the exact same versions of every dependency. Its use is strongly encouraged by npm.

@BigBlueHat
Copy link
Member

@thornjad we should try and get package-lock.json updated and committed before the next release. It is, as you've noted, the new normal. 😃

@BigBlueHat BigBlueHat added the minor version non-breaking, non-trivial change label Aug 8, 2018
@thornjad
Copy link
Member Author

thornjad commented Aug 8, 2018

Perfect! I just updated this PR so the package-lock.json is up to date with master.

@BigBlueHat BigBlueHat merged commit b1b266c into http-party:master Aug 8, 2018
@BigBlueHat
Copy link
Member

Thanks @thornjad!

jimlawhorn added a commit to jimlawhorn/http-server that referenced this pull request Aug 10, 2018
jimlawhorn pushed a commit to jimlawhorn/http-server that referenced this pull request Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor version non-breaking, non-trivial change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants